fix: prevent Hindsight retain work during interpreter shutdown#15512
Open
vominh1919 wants to merge 1 commit into
Open
fix: prevent Hindsight retain work during interpreter shutdown#15512vominh1919 wants to merge 1 commit into
vominh1919 wants to merge 1 commit into
Conversation
Add shutdown guard to sync_turn() and defense-in-depth loop.is_closed() check in _run_sync() to prevent RuntimeError during interpreter teardown. Fixes NousResearch#15497
Collaborator
3 tasks
Contributor
|
Superseded by #17005 (merged) which adopts a single-writer queue + |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15497
Problem
The
HindsightMemoryProvidercan still submit async retain work after provider shutdown has started. During interpreter teardown,asyncio.run_coroutine_threadsafe()fails withRuntimeError: cannot schedule new futures after interpreter shutdown.Root Cause
shutdown()joins existing threads but has no guard flag to preventsync_turn()from accepting new work.Fix
self._shutting_down = Falsein__init__()— initializes the guard flagsync_turn()— checksself._shutting_downbefore doing any workself._shutting_down = Trueat top ofshutdown()— marks provider as shutting down before joining threads_run_sync()— checksloop.is_closed()before callingasyncio.run_coroutine_threadsafe()Files Changed
plugins/memory/hindsight/__init__.py— 7 lines added, 0 removed