Skip to content

fix: omit temperature for Codex auxiliary calls#15443

Closed
stefan-mcf wants to merge 1 commit into
NousResearch:mainfrom
stefan-mcf:fix/codex-auxiliary-omit-temperature
Closed

fix: omit temperature for Codex auxiliary calls#15443
stefan-mcf wants to merge 1 commit into
NousResearch:mainfrom
stefan-mcf:fix/codex-auxiliary-omit-temperature

Conversation

@stefan-mcf

Copy link
Copy Markdown

Summary

  • Omit temperature for auxiliary calls routed to the Codex Responses backend (chatgpt.com/backend-api/codex)
  • Prevents auxiliary memory flush from failing with HTTP 400 Unsupported parameter: temperature
  • Keeps the change scoped to the existing model/endpoint temperature-directive helper

Test Plan

  • python -m pytest tests/run_agent/test_flush_memories_codex.py -o 'addopts=' -q
  • Directly verified _build_call_kwargs(...) omits temperature for https://chatgpt.com/backend-api/codex/

Codex Responses endpoints reject sampling parameters such as temperature. When auxiliary tasks like flush_memories route through chatgpt.com/backend-api/codex, strip temperature before creating the request.
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/agent Core agent loop, run_agent.py, prompt builder provider/copilot GitHub Copilot (ACP + Chat) labels Apr 25, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks @stefan-mcf! The Codex Responses temperature rejection is now handled on main via two complementary fixes: #15620 (strips temperature from the flush_memories codex_responses fallback) and #15623 (universal reactive retry — catches the 400 from any provider/model combo, not just Codex ChatGPT). The reactive approach covers your base-url-match case and more. Closing as superseded — credit to you for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent loop, run_agent.py, prompt builder P2 Medium — degraded but workaround exists provider/copilot GitHub Copilot (ACP + Chat) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants