fix(agent): clear compressor state on session start to prevent cross-session task leakage (#14603)#15368
Open
Tranquil-Flow wants to merge 2 commits into
Open
Conversation
This was referenced Apr 26, 2026
…session task leakage (NousResearch#14603)
c3a1e43 to
cc98c9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ContextCompressor._previous_summarypersists across session boundaries when the same cachedAIAgentinstance is reused in the gateway or cron. When a new session starts without an explicit/reset,on_session_start()is called buton_session_reset()is not. Sinceon_session_start()is a no-op on the baseContextEngine,_previous_summaryfrom the old session leaks into the next session's iterative summary update, causing old task context (e.g. "## Active Task: Deploy the web server") to bleed into the new session's compression summary.This PR overrides
on_session_start()onContextCompressorto clear_previous_summaryand_ineffective_compression_count, ensuring a fresh compressor state when a new session begins while preserving the more thorough cleanup inon_session_reset()for explicit/newor/reset.Related Issue
Fixes #14603
Type of Change
Changes Made
agent/context_compressor.py: Overrideon_session_start()to clear_previous_summaryand_ineffective_compression_count.tests/agent/test_compressor_session_isolation.py: 3 targeted tests:on_session_startclears_previous_summary.on_session_resetstill works as before.How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
N/A — see commit description and PR diff.