fix(gateway): remove recursive ExecStop from both systemd units#1530
Merged
Conversation
The cherry-picked PR #1448 fix only covered the user systemd unit. The system unit had the same TimeoutStopSec=15 and could benefit from the same 60s timeout for clean shutdown. Also adds a regression test for the system unit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of PR #1448 by @EmpireOperating — cherry-picked onto current main with authorship preserved, extended to cover the system unit too.
Problem
The user systemd unit had
ExecStop=hermes gateway stop, which callssystemctl --user stop hermes-gatewayon the very unit being stopped — recursive and timeout-prone.Fix
ExecStop, bumpTimeoutStopSec15→60TimeoutStopSec15→60 bump (system unit already lacked ExecStop)920 gateway tests + 8 service tests pass.