test(ink): add bidi regression coverage for mixed Arabic/English text#15238
Open
raheb77 wants to merge 1 commit into
Open
test(ink): add bidi regression coverage for mixed Arabic/English text#15238raheb77 wants to merge 1 commit into
raheb77 wants to merge 1 commit into
Conversation
10 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a small tests-only regression suite for mixed Arabic/English bidi rendering in Hermes Ink.
This change does not introduce locale plumbing, translation files, or runtime behavior changes. It only documents and protects the current bidi behavior for a realistic RTL/LTR mixed-text case in the TUI layer.
Related Issue
Refs #12375
Type of Change
Changes Made
ui-tui/packages/hermes-ink/src/ink/bidi.test.tsمرحبا gpt-5How to Test
cd ui-tui/packages/hermes-inknpm test -- packages/hermes-ink/src/ink/bidi.test.tsChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
N/A — tests-only change.