fix(deepseek): preserve v4 model IDs#14947
Closed
anthonylei wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Duplicate of #14946 — identical fix (add V4 ids to _DEEPSEEK_CANONICAL_MODELS), same files changed, same root cause. |
This was referenced Apr 24, 2026
Contributor
|
Thanks for the contribution, @anthonylei! This is a valid bug fix and the diagnosis is correct. Unfortunately this is a duplicate — the identical change (adding
Closing as implemented on main. This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Preserves explicit DeepSeek V4 public API model IDs during native DeepSeek model normalization.
Before this change, configuring
deepseek-v4-proordeepseek-v4-flashfor the nativedeepseekprovider silently normalized the model todeepseek-chat. That made Hermes appear to work while calling a different model than the user explicitly requested.This keeps the change narrow: only the DeepSeek accepted-model allowlist is expanded, while legacy aliases and reasoner-style alias normalization keep their existing behavior.
Related Issue
No issue filed.
Type of Change
Changes Made
hermes_cli/model_normalize.pydeepseek-v4-flashanddeepseek-v4-profor the nativedeepseekprovider.deepseek-chatanddeepseek-reasoneraliases working.deepseek-r1,deepseek-reasoning, anddeepseek-thinkmapping todeepseek-reasoner.tests/hermes_cli/test_model_normalize.pydeepseek/-prefixed V4 model IDs.deepseek-reasoner.How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Focused regression test:
Full model-normalization test file:
Independent local review was also requested from Claude Code Opus 4.7, Kimi 2.6 via Kimi Code CLI, and DeepSeek V4 Pro. All approved with no blocking issues.