Skip to content

fix: path traversal in signal file:// and expand dangerous command patterns#14924

Open
binbinao wants to merge 1 commit into
NousResearch:mainfrom
binbinao:upstream-fix/security-path-traversal
Open

fix: path traversal in signal file:// and expand dangerous command patterns#14924
binbinao wants to merge 1 commit into
NousResearch:mainfrom
binbinao:upstream-fix/security-path-traversal

Conversation

@binbinao

Copy link
Copy Markdown

Summary

Security fixes:

  1. Path traversal in Signal file:// image handler - added is_relative_to() check
  2. Missing dangerous command patterns in approval.py - added sudo -S, alias, disown, crontab -e/-u, fixed fork bomb regex

Files: gateway/platforms/signal.py, tools/approval.py

@alt-glitch alt-glitch added type/security Security vulnerability or hardening P1 High — major feature broken, no workaround platform/signal Signal CLI adapter comp/tools Tool registry, model_tools, toolsets labels Apr 24, 2026
…tterns

- Add is_relative_to check for signal file:// image paths
- Fix fork bomb regex: remove trailing colon that allowed bypass
- Add patterns for: sudo -S, alias, disown, crontab -e/-u
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/tools Tool registry, model_tools, toolsets P1 High — major feature broken, no workaround platform/signal Signal CLI adapter type/security Security vulnerability or hardening

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants