fix(packaging): include web_dist assets in sdist and improve missing-frontend error#14918
Closed
aniruddhaadak80 wants to merge 1 commit into
Closed
fix(packaging): include web_dist assets in sdist and improve missing-frontend error#14918aniruddhaadak80 wants to merge 1 commit into
aniruddhaadak80 wants to merge 1 commit into
Conversation
…frontend error MANIFEST.in did not graft hermes_cli/web_dist, so the frontend assets were excluded from sdist builds. This caused pip installs from the source tarball (and any downstream sdist-based packaging) to ship without the dashboard UI, returning a 404 with an unhelpful error message. - Add 'graft hermes_cli/web_dist' to MANIFEST.in - Improve the no-frontend error message to suggest both pip reinstall (hermes-agent[web]) and the dev build command Closes NousResearch#14880
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14880
The built wheel/sdist is missing
hermes_cli/web_dist/frontend assets, causing the dashboard to return a 404 with an unhelpful error message when accessed.Root Cause
MANIFEST.inonly graftsskillsandoptional-skillsdirectories. Whilepyproject.tomldeclareshermes_cli = ["web_dist/**/*"]in[tool.setuptools.package-data], the sdist tarball itself doesn't include theweb_distdirectory becauseMANIFEST.indoesn't graft it. When a wheel is built from the sdist (e.g. in CI/CD pipelines or downstream packagers), the assets are silently excluded.Changes
MANIFEST.in:
graft hermes_cli/web_distto ensure the frontend assets are included in sdist buildshermes_cli/web_server.py —
mount_spa():pip install hermes-agent[web]for pip users alongside the existing dev build commandTesting
MANIFEST.ingraft is additive — ifweb_dist/doesn't exist at build time, the graft is a no-op (no build failure)pyproject.tomlpackage-data glob (web_dist/**/*) already handles wheel inclusion; the MANIFEST.in graft covers the sdist pathChecklist