fix(honcho): CLI credential guard rejects self-hosted baseUrl configs#14881
Closed
sasha-id wants to merge 1 commit into
Closed
fix(honcho): CLI credential guard rejects self-hosted baseUrl configs#14881sasha-id wants to merge 1 commit into
sasha-id wants to merge 1 commit into
Conversation
_resolve_api_key() only checks for apiKey / HONCHO_API_KEY, so all CLI subcommands (identity --show, status, migrate, etc.) bail with "No API key configured" on self-hosted instances that use baseUrl without an API key. Return "local" when baseUrl or HONCHO_BASE_URL is set, matching the client.py behavior that already handles this case for the SDK. Tested on: macOS, self-hosted Honcho (Docker, localhost:8000).
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_resolve_api_key()inplugins/memory/honcho/cli.pyonly checks forapiKey/HONCHO_API_KEY, causing all CLI subcommands (hermes honcho identity --show,status,migrate, etc.) to bail with "No API key configured" on self-hosted instances that usebaseUrlwithout an API key.client.py) already handles this case correctly by using"local"as a placeholder — this fix brings the CLI guard in line with that behavior."local"whenbaseUrl/base_url/HONCHO_BASE_URLis set but no API key is configured.Test plan
_resolve_api_keycovering: root key, host block key, baseUrl without key, HONCHO_BASE_URL env var, and empty configpytest tests/honcho_plugin/test_cli.py -v)hermes honcho identity --shownow proceeds past the credential checkPlatforms tested