Use reasoning content for context summaries#14847
Closed
cocojojo5213 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Likely overlaps with #4603 which targets the same code path (extract_content_or_reasoning for compression). Please coordinate or close one. |
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extract_content_or_reasoning().message.contentpayloads.Why
Some OpenAI-compatible reasoning runtimes can return
message.content=Nonewhile placing usable text in structured reasoning fields. Context compression previously readresponse.choices[0].message.contentdirectly, which caused the generated summary to be empty even whenextract_content_or_reasoning()could recover the text.This also keeps the existing llama.cpp-style non-string content path working after switching the compressor to the shared extraction helper.
Validation
python -m pytest tests/agent/test_context_compressor.py -q