fix(agent): scope subdirectory hint discovery to active workspace boundary#14795
Open
Tranquil-Flow wants to merge 1 commit into
Open
fix(agent): scope subdirectory hint discovery to active workspace boundary#14795Tranquil-Flow wants to merge 1 commit into
Tranquil-Flow wants to merge 1 commit into
Conversation
Collaborator
b027e84 to
8ae2a17
Compare
2 tasks
8ae2a17 to
4056d14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Post-tool-call path discovery scanned any directory for
AGENTS.md,CLAUDE.md, and.cursorrulesfiles, even those outside the intended workspace. A tool call touching a file elsewhere on disk could silently inject unrelated instruction files into the agent context, causing unexpected behavior drift and cross-project leakage.Related Issue
Fixes #14471
Type of Change
Changes Made
agent/subdirectory_hints.py: Scoped discovery to active workspace boundarytests/agent/test_subdirectory_hints.py: 26 testsHow to Test
python -m pytest -o 'addopts=' tests/agent/test_subdirectory_hints.py -vResult: 26 passed.
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs