fix(agent): classify overloaded errors as server-side overload, not rate_limit#14788
Open
Tranquil-Flow wants to merge 2 commits into
Open
fix(agent): classify overloaded errors as server-side overload, not rate_limit#14788Tranquil-Flow wants to merge 2 commits into
Tranquil-Flow wants to merge 2 commits into
Conversation
Collaborator
fe08fdb to
df751ef
Compare
df751ef to
20ba77a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a provider returns an overloaded message (e.g. Z.AI code 1305: "temporarily overloaded, please try again later"), the "try again" substring matched
_RATE_LIMIT_PATTERNS, causing it to be classified asrate_limitwithshould_rotate_credential=True. This exhausted the credential pool for what is actually a server-side capacity issue.Related Issue
Fixes #14038
Type of Change
Changes Made
agent/error_classifier.py: Added overloaded error classification distinct from rate_limittests/agent/test_error_classifier.py: Tests for overloaded classification (121 passed in full suite)How to Test
python -m pytest -o 'addopts=' tests/agent/test_error_classifier.py -vChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs