fix(tools): add defensive type coercion in todo_tool for malformed LLM input#14785
Open
Tranquil-Flow wants to merge 2 commits into
Open
fix(tools): add defensive type coercion in todo_tool for malformed LLM input#14785Tranquil-Flow wants to merge 2 commits into
Tranquil-Flow wants to merge 2 commits into
Conversation
Collaborator
This was referenced May 10, 2026
fd35cbd to
62f44a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds defensive type coercion in
todo_tool.pyfor cases where LLMs emit todo items as JSON strings instead of dicts, causingAttributeError: 'str' object has no attribute 'get'.Related Issue
Fixes #14185
Type of Change
Changes Made
tools/todo_tool.py: Added type coercion for malformed LLM inputtests/tools/test_todo_tool_type_coercion.py: 13 testsHow to Test
python -m pytest -o 'addopts=' tests/tools/test_todo_tool_type_coercion.py -vResult: 13 passed.
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs