fix(skills): follow symlinked category dirs consistently#14740
Merged
Conversation
005aaf1 to
221d032
Compare
14 tasks
This was referenced Apr 27, 2026
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #14668 by @helix4u onto current main.
Summary
Symlinked category dirs under
~/.hermes/skills/are now fully discovered —skills_list(),skill_view(name=...), and slash-command scanning all see them.Root cause
iter_skill_index_files()was fixed to useos.walk(followlinks=True)back in commit 02aba4a, but three residualPath.rglob("SKILL.md")scan sites were never migrated.Path.rglobdoes not follow directory symlinks;os.walk(followlinks=True)does.Changes
tools/skills_tool.py:_find_all_skills()and name-search inskill_view()switched toiter_skill_index_files()agent/skill_commands.py:scan_skill_commands()switched to the same iterator_sort_skills()helper soskills_list()order matches theskill_view()not-found hintValidation
scripts/run_tests.sh tests/tools/test_skills_tool.py tests/agent/test_skill_commands.py tests/agent/test_external_skills.py— 124/124 pass.Closes #14668 (salvage with original authorship preserved via rebase-merge).