fix: validate nous auth status against runtime credentials#14671
Closed
mssteuer wants to merge 1 commit into
Closed
fix: validate nous auth status against runtime credentials#14671mssteuer wants to merge 1 commit into
mssteuer wants to merge 1 commit into
Conversation
This was referenced Apr 24, 2026
Contributor
|
This fix has already landed on Automated hermes-sweeper review. The exact changes from this PR were squash-merged into
Thanks for the solid fix, @mssteuer — the P1 label was well-earned and the change made it in quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_nous_auth_status()prefer auth-store provider state over stale credential-pool entrieshermes statusTest Plan
python -m pytest -q -o addopts='' tests/hermes_cli/test_auth_nous_provider.py tests/hermes_cli/test_status.py tests/hermes_cli/test_nous_subscription.pyWhy
A revoked Nous refresh session could leave
hermes statusclaiming the user was logged in because it only saw token-shaped data on disk. In one real case, stale credential-pool data also overrode fresher auth-store data, so status showed the wrong expiries after re-auth.This change makes the status path use the same source of truth as runtime credential minting and report the failure honestly.