fix: increment request_count in least_used credential pool strategy#14631
Closed
vominh1919 wants to merge 1 commit into
Closed
fix: increment request_count in least_used credential pool strategy#14631vominh1919 wants to merge 1 commit into
vominh1919 wants to merge 1 commit into
Conversation
The least_used strategy selected entries via min(request_count) but never incremented the counter. All entries stayed at count=0, so the strategy degenerated to fill_first behavior with no actual load balancing. Now increments request_count after each selection and persists the update.
Collaborator
|
Likely duplicate of #4453 — same root cause: |
Contributor
|
Thanks for the fix @vominh1919! This change has already landed on
Closing as implemented on main. The regression test you added ( This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
least_usedcredential pool strategy selects entries viamin(request_count), but never increments the counter. Since all entries start atrequest_count=0, the strategy degenerates tofill_firstbehavior — it always returns the first available entry with no actual load balancing.Fix
Increments
request_counton the selected entry after eachselect()call, and persists the update via_replace_entry().Before vs After
Tests
TestLeastUsedStrategy