Fix WeCom media decryption for unpadded aeskey#14580
Open
freefish1218 wants to merge 1 commit into
Open
Conversation
Author
|
Tests completed locally:
|
Collaborator
This was referenced Apr 24, 2026
This was referenced May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix WeCom inbound media decryption when the message
aeskeyis sent as an unpadded Base64 string.What changed
aeskeybefore Base64 decodingaeskeyWhy
In real WeCom bot traffic, inbound image media could fail with:
Incorrect paddingThe adapter was decoding
aeskeywithbase64.b64decode(aes_key)directly. Some WeCom media messages provide the AES key in unpadded Base64 form, so decoding fails before AES-CBC decryption begins.This patch pads the key to a multiple of 4 before decoding, matching the behavior used by other WeCom implementations.
Validation
Production validation:
Incorrect paddingAutomated tests:
./.venv/bin/python -m pytest -q tests/gateway/test_wecom.py -k "decrypt_file_bytes"->2 passed./.venv/bin/python -m pytest -q tests/gateway/test_wecom.py->41 passed