fix: avoid reusing Weixin sessions across event loops#14481
Open
timfaner wants to merge 1 commit into
Open
Conversation
This was referenced Apr 24, 2026
This was referenced May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send_weixin_direct()from reusing a live Weixin adapter unless its aiohttp session belongs to the current event loopaiohttp.ClientSessionwhen the cached live adapter is bound to a different loopRoot cause
When cron delivery hit the Weixin fallback path after an initial send failure, it could reuse a live adapter/session created by the long-running gateway loop. If that session belonged to a different asyncio event loop than the current cron delivery context, aiohttp could fail with:
Timeout context manager should be used inside a taskThat turned one recoverable Weixin send failure into a second Hermes-side delivery failure.
Fix
Gate live-adapter reuse on loop affinity:
asyncio.get_running_loop()Verification
test_send_weixin_direct_ignores_live_adapter_bound_to_different_looppython -m pytest tests/gateway/test_weixin.py -q -o 'addopts='43 passedNotes
This fixes the Hermes fallback bug. It does not change the upstream iLink error behavior itself; it prevents the fallback path from failing for an unrelated cross-event-loop reason.