Skip to content

fix: clarify auth list exhausted status#14449

Closed
andyylin wants to merge 2 commits into
NousResearch:mainfrom
andyylin:fix/auth-list-status-clarity
Closed

fix: clarify auth list exhausted status#14449
andyylin wants to merge 2 commits into
NousResearch:mainfrom
andyylin:fix/auth-list-status-clarity

Conversation

@andyylin

@andyylin andyylin commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • label 429/quota cooldowns as rate limits instead of generic exhaustion
  • label 401/403-style credential problems as auth failures instead of implying wait-and-retry
  • add auth command coverage for both cases

Test Plan

  • source /home/pi/.hermes/hermes-agent/venv/bin/activate && python -m pytest tests/hermes_cli/test_auth_commands.py -q

@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard area/auth Authentication, OAuth, credential pools labels Apr 23, 2026
@teknium1 teknium1 mentioned this pull request Apr 24, 2026
Merged
@teknium1

teknium1 commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Thanks for this contribution @andyylin! The changes from this PR have been picked up and are already live on main.

This is an automated hermes-sweeper review.

Evidence:

  • _classify_exhausted_status() is present in hermes_cli/auth_commands.py at line 113, with rate-limited and auth failed labels and the re-auth may be required message — exactly the UX improvements from this PR.
  • Commit fff7ee31a (fix: clarify auth retry guidance) by @andyylin appears directly in main's history for this file.
  • This PR was explicitly credited in the consolidated credential-pool salvage PR fix(credential-pool): correctness + rotation + cross-process sync #15120 (now merged), which describes: "_classify_exhausted_status() distinguishes rate-limited (429/"rate_limit"/"quota" markers) from auth failures (401/403/"invalid_token"/"unauthorized") in hermes auth list output.`

The fix is shipped. Closing as implemented on main.

@teknium1 teknium1 closed this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/auth Authentication, OAuth, credential pools comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/refactor Code restructuring, no behavior change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andyylin @teknium1 @alt-glitch