fix(resume): accept unique truncated title prefixes#14411
Open
sgaofen wants to merge 1 commit into
Open
Conversation
Collaborator
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14082.
This lets
/resume <title>recover sessions when the user copies the width-limited title shown by the recent-session list.Root cause
/resumetells users they can resume by session ID or title, but the recent-session table truncates titles. The resolver only accepted exact title matches (plus lineage suffixes), so copying the displayed title prefix failed withSession not found.Fix
Validation
/Users/stephenyu/Documents/hermes-agent/.venv/bin/python -m pytest tests/test_hermes_state.py::TestTitleLineage::test_resolve_blank_title_returns_none tests/test_hermes_state.py::TestTitleLineage::test_resolve_unique_title_prefix_from_truncated_display tests/test_hermes_state.py::TestTitleLineage::test_resolve_ambiguous_title_prefix_returns_none tests/test_hermes_state.py::TestTitleLineage::test_resolve_exact_title tests/test_hermes_state.py::TestTitleLineage::test_resolve_returns_latest_numbered tests/test_hermes_state.py::TestTitleSqlWildcards::test_resolve_title_with_percent tests/test_hermes_state.py::TestTitleSqlWildcards::test_resolve_title_with_underscore -q --tb=short/Users/stephenyu/Documents/hermes-agent/.venv/bin/python -m pytest tests/test_hermes_state.py -q --tb=shortgit diff --check