Skip to content

fix: clear stale api keys when switching API-key providers#14373

Open
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/clear-stale-api-key-on-provider-switch-14134
Open

fix: clear stale api keys when switching API-key providers#14373
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:fix/clear-stale-api-key-on-provider-switch-14134

Conversation

@LeonSGP43

@LeonSGP43 LeonSGP43 commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • clear stale inline model.api_key values when switching API-key providers in hermes model
  • keep provider/base URL updates while removing leftover credentials from the previous provider
  • add a regression test covering a switch from OpenRouter to a generic API-key provider

Testing

  • python3 -m pytest -o addopts= tests/hermes_cli/test_model_provider_persistence.py

Closes #14134.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard labels Apr 23, 2026
@alt-glitch

alt-glitch commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

Likely duplicate of #14370 — same root cause (stale api_key on provider switch in hermes_cli/main.py), same target issue #14134. Also related to #8571.

@alt-glitch alt-glitch mentioned this pull request Apr 23, 2026
Closed
@alt-glitch alt-glitch mentioned this pull request May 2, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: api_key drift on provider switch — real Hermes bug

2 participants

@LeonSGP43 @alt-glitch