fix(gateway): ignore invoking CLI ancestor during PID scan#14177
Closed
liuhao1024 wants to merge 1 commit into
Closed
fix(gateway): ignore invoking CLI ancestor during PID scan#14177liuhao1024 wants to merge 1 commit into
liuhao1024 wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing inactive PR with no discussion. Opened 2026-04-22 with 0 comments. Will reopen if still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
find_gateway_pids()scans process-table matches broadly enough to see the foreground CLI process that launchedhermes gateway run --replace. Because the scan only excluded the current PID, an ancestor in the same process tree could still be reported as an already-running gateway.Fix
Restrict the ancestor filter to
_scan_gateway_pids()so only process-table matches are skipped when they belong to the current process tree. This preserves the existing PID-file fallback and service PID discovery paths.Regression coverage
TestFindGatewayPidsExclude::test_excludes_ancestor_process_treegateway/run.pyprocess is still returnedTesting
scripts/run_tests.sh tests/hermes_cli/test_update_gateway_restart.py::TestFindGatewayPidsExclude::test_excludes_ancestor_process_treescripts/run_tests.sh tests/hermes_cli/test_update_gateway_restart.pyscripts/run_tests.sh tests/hermes_cli/test_gateway.pyCloses #13242