fix(agent): detect custom provider context length for auto-mode compression#14023
Closed
pbastowski wants to merge 2 commits into
Closed
fix(agent): detect custom provider context length for auto-mode compression#14023pbastowski wants to merge 2 commits into
pbastowski wants to merge 2 commits into
Conversation
pbastowski
commented
Apr 22, 2026
- Added _get_custom_provider_context_length() helper to query custom_providers config for context length
- Integrated step 0b in get_model_context_length() to consult custom_providers before probe tiers
- Preserves auto flexibility (no hardcoded model names) by matching on base_url
…ession - Added _get_custom_provider_context_length() helper to query custom_providers config for context length - Integrated step 0b in get_model_context_length() to consult custom_providers before probe tiers - Preserves auto flexibility (no hardcoded model names) by matching on base_url
27544fd to
66f1ab4
Compare
- test_returns_context_length_from_custom_provider - test_returns_none_when_base_url_does_not_match - test_returns_provider_level_context_length - test_case_insensitive_model_match - test_returns_none_when_import_fails
Collaborator
Collaborator
Contributor
|
Thank you for this contribution, @pbastowski! This is a well-scoped fix with good test coverage. After an automated hermes-sweeper review, the fix proposed here has since been implemented on
The companion issue #13807 / #12977 and PR #13813 remain open — a maintainer may want to verify those are fully resolved by #15844 as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.