Fix stale gateway PID recovery and add systemd startup cleanup#14002
Closed
qwertysc wants to merge 1 commit into
Closed
Fix stale gateway PID recovery and add systemd startup cleanup#14002qwertysc wants to merge 1 commit into
qwertysc wants to merge 1 commit into
Conversation
Collaborator
Collaborator
|
Likely duplicate of #13709 |
This was referenced Apr 22, 2026
Contributor
|
Thanks for the detailed write-up and the regression coverage! The core fix here — replacing the defensive Evidence:
The This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gateway.pidrecords during runtime PID checksExecStartPrestartup cleanup to generated systemd units so stale PID files self-heal before launchTesting
venv/bin/python -m pytest -q tests/gateway/test_status.py tests/hermes_cli/test_gateway_service.pyBackground
This fixes the restart loop where an unclean shutdown leaves
gateway.pidbehind, systemd kills the old process after timeout, and the next startup fails withPID file race lost to another gateway instance. The fix is split across core correctness (PID cleanup) and service-level self-healing (systemdExecStartPre).