fix(tui): fix status bar width fluctuation by capping model name width (Closes #13610)#13806
Closed
ms-alan wants to merge 3 commits into
Closed
fix(tui): fix status bar width fluctuation by capping model name width (Closes #13610)#13806ms-alan wants to merge 3 commits into
ms-alan wants to merge 3 commits into
Conversation
3 tasks
Collaborator
|
Superseded by #17150 (merged) — status bar ticker width stabilization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The TUI status bar's model name field had no width constraint, so when the ticker cycled between model names of different lengths, the entire status bar grew and shrank — creating a jarring visual experience.
Fix: Wrap the model name in a fixed-width
<Text width={18} wrap="truncate-end">container. Long names are truncated with ellipsis, short names stay left-aligned, and the status bar layout remains stable.Changes
ui-tui/src/components/appChrome.tsx: Give the model name a fixedwidth={18}withtruncate-endwrappingTesting
hermes --tui→ observe status bar width stays stable as model name changesCloses #13610