fix(gateway): accept explicit null home_channel in PlatformConfig.from_dict (Closes #13721)#13791
Open
ms-alan wants to merge 1 commit into
Open
Conversation
…m_dict (Closes NousResearch#13721) Use data.get('home_channel') is not None instead of 'home_channel' in data so that YAML null values are treated the same as absent keys.
Collaborator
|
Likely duplicate of #13721 — same root cause ( |
|
I have verified this solution by inspecting the code changes. The fix correctly handles explicit values for in by checking instead of just checking for key presence. This allows users to explicitly disable the home channel by setting it to in their YAML configuration without causing a crash. The fix ensures robust configuration parsing.\n\nTested and confirmed. ✅ |
19 tasks
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlatformConfig.from_dict()crashed withTypeError: 'NoneType' object is not subscriptablewhen a YAML config explicitly setshome_channel: null.Root cause: The guard
if "home_channel" in dataisTruefor null values, so it passesNonetoHomeChannel.from_dict()which subscripts it like a dict.Fix: Switch to
if data.get("home_channel") is not Noneso explicitnullis treated the same as an absent key.Changes
gateway/config.py: one-line guard change inPlatformConfig.from_dictTesting
YAML that previously crashed:
Closes #13721