Invoke session finalize hooks on expiry flush#13756
Closed
dimitrovi wants to merge 1 commit into
Closed
Conversation
Collaborator
Collaborator
|
I have tested this solution locally. The session finalize hooks now fire correctly upon expiry flush. This ensures that when sessions expire or are flushed, the appropriate cleanup hooks fire correctly, preventing resource leaks and ensuring data consistency. The fix is stable and ready for merge.\n\nTested and confirmed. ✅ |
1 task
Contributor
|
Merged via #15132 — your commit was cherry-picked onto current main with authorship preserved in Thanks for the clean, focused fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on_session_finalizeplugin hook after successful expiry-driven memory flushesWhy
DIM memory automation relies on session finalization side effects after idle expiry. Without this hook, Hermes flushes provider memory but does not trigger the profile-local capture path.