Fix Slack mention gating and workspace routing#13455
Closed
0xchloe996 wants to merge 2 commits into
Closed
Conversation
Contributor
|
Closing in favor of the narrower salvage in #16193. Your PR solved a real problem (thread auto-engagement in multi-agent scenarios), but the scope made it hard to merge as-is: +414/-136 across 10 files changed the default behavior in public channels and mixed in unrelated workspace-routing and allowed_users changes. The mention-gating piece is superseded by #16193's opt-in If you want the workspace routing / Socket Mode envelope team_id fix to land, please open a focused PR for just that piece — the code looked right, it was just coupled to the larger diff. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SLACK_ALLOWED_USERSonly to Slack DMs so allowed channels can respond to any user who mentions the botchannel_not_foundTesting