fix(tui): follow compression tips when resuming sessions#13374
Open
Tosko4 wants to merge 1 commit into
Open
Conversation
798006b to
6f56e84
Compare
This was referenced Apr 24, 2026
ecf7d67 to
775e641
Compare
775e641 to
f88a122
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.resumefollow compression continuations throughdb.get_compression_tip(...)Why
A resumed compressed conversation could appear to lose post-compaction messages because
session.resumereopened the old root session instead of the latest continuation tip. The data was still present in session lineage, but this path was not following it.Validation
./scripts/run_tests.sh -n 0 tests/tui_gateway/test_protocol.py tests/test_hermes_state.py -q --tb=short,266 passedpython -m compileall -q tui_gateway/server.py tests/tui_gateway/test_protocol.pygit diff --check origin/main...HEADNotes
mainafter fix(ci): unblock shared PR checks #21012 so the old shared baseline commit is no longer part of this PR