fix: avoid cross-loop reuse in weixin direct send#13350
Closed
ifnodoraemon wants to merge 1 commit into
Closed
Conversation
- only reuse the live adapter session when it belongs to the current event loop - fall back to an isolated aiohttp session on loop mismatch - add regression tests for same-loop and cross-loop direct sends
Collaborator
|
Likely duplicate of #13520 — same root cause: cross-event-loop aiohttp session reuse in Weixin direct send path. |
1 similar comment
Collaborator
|
Likely duplicate of #13520 — same root cause: cross-event-loop aiohttp session reuse in Weixin direct send path. |
This was referenced Apr 22, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Weixin direct sends could reuse a live adapter session created on the gateway loop from a different event loop used by the send_message tool path. That produced runtime failures like:
Testing
python -m pytest tests/gateway/test_weixin.py -q -o 'addopts='python -m pytest tests/tools/test_send_message_tool.py -q -o 'addopts='Verification