Skip to content

fix(tests): collect web tools integration checks#13335

Open
sgaofen wants to merge 1 commit into
NousResearch:mainfrom
sgaofen:codex/fix-13287-web-tools-pytest
Open

fix(tests): collect web tools integration checks#13335
sgaofen wants to merge 1 commit into
NousResearch:mainfrom
sgaofen:codex/fix-13287-web-tools-pytest

Conversation

@sgaofen

@sgaofen sgaofen commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Fixes #13287.

Root cause:
tests/integration/test_web_tools.py looked like a pytest integration module but only exposed a manual script-style harness, so pytest collected zero tests from the file.

Fix summary:

  • Add real pytest-collectable wrappers for search, extraction without LLM, extraction with LLM, and crawl flows.
  • Keep the manual script entry point intact.
  • Gate live web checks behind existing web backend credential detection so default local/CI runs skip safely instead of making unauthenticated external calls.
  • Add structure/content assertions for enabled integration runs.

Tests:

  • uv run --frozen --python 3.11 --extra dev pytest -o addopts= --collect-only tests/integration/test_web_tools.py -> 4 tests collected
  • uv run --frozen --python 3.11 --extra dev pytest -o addopts= tests/integration/test_web_tools.py -q -> 4 skipped
  • git diff --check -- tests/integration/test_web_tools.py

@alt-glitch alt-glitch added type/test Test coverage or test infrastructure P3 Low — cosmetic, nice to have tool/web Web search and extraction labels Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low — cosmetic, nice to have tool/web Web search and extraction type/test Test coverage or test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: tests/integration/test_web_tools.py is named like a pytest module but collects zero tests

2 participants