fix(setup): recognize gateway-managed tools#13327
Open
sgaofen wants to merge 1 commit into
Open
Conversation
0215b80 to
534aee9
Compare
Contributor
Author
|
Rebased this onto current One note on the Supply Chain Audit failure: this PR intentionally touches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tts.use_gateway,browser.use_gateway,web.use_gateway, andimage_gen.use_gatewayas configured tools in setup summariesRoot Cause
hermes setuponly looked for direct provider API keys such asFIRECRAWL_API_KEYandBROWSERBASE_API_KEYwhen deciding whether the tools section was configured. Gateway-managed tools persist intent in config viause_gateway: true, so they were incorrectly reported as unconfigured.Tests
uv run --frozen --python 3.11 --extra dev pytest -o addopts='' tests/hermes_cli/test_setup.py -q(20 passed)git diff --check -- hermes_cli/setup.py tests/hermes_cli/test_setup.py