Skip to content

fix: salvage tier-1 bug fixes from PRs #7387, #9091, #6293, #13131#13187

Merged
teknium1 merged 7 commits into
mainfrom
hermes/hermes-eaac5e6d
Apr 20, 2026
Merged

fix: salvage tier-1 bug fixes from PRs #7387, #9091, #6293, #13131#13187
teknium1 merged 7 commits into
mainfrom
hermes/hermes-eaac5e6d

Conversation

@teknium1

@teknium1 teknium1 commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Salvages four community bug fixes onto current main with contributor authorship preserved.

Changes

PR #7387 (@dsocolobsky) — fix(telegram): handle parentheses in URLs during MarkdownV2 link conversion

  • 1-line regex fix in telegram.py for Wikipedia-style URLs with balanced parens

PR #9091 (@dsocolobsky) — fix(tui): make "/tools list" show real colors instead of garbled ANSI

  • Captures stdout via redirect_stdout and re-renders through _cprint() in interactive TUI mode

PR #6293 (@dsocolobsky) — fix(discord): slash command detection when auto-create-thread is on

  • Saves mention-stripped text before create_thread() clobbers message.content
  • Uses normalized_content for command detection and event text
  • Adds e2e tests for Discord mention stripping + command dispatch

PR #13131 (@IAvecilla) — fix: update openclaw migration env var detection

  • Replaces hardcoded env-var checks with dynamic PROVIDER_REGISTRY and _GATEWAY_PLATFORMS lookups
  • Fixes wrong env vars (SIGNAL_ACCOUNT, WHATSAPP_PHONE_NUMBER_ID) and adds missing providers

Follow-up fixes

  • Fix duplicate timezone import in e2e conftest
  • Fix test assertion for non-command text messages (no agent in mock = no send call)
  • Add AUTHOR_MAP entries for lambdaclass.com emails

Validation

Test suite Result
tests/gateway/test_telegram_format.py 88 passed
tests/e2e/test_discord_adapter.py 6 passed
tests/e2e/ (full) 54 passed
tests/hermes_cli/test_setup_openclaw_migration.py 33 passed

dsocolobsky and others added 7 commits April 20, 2026 14:01
@dsocolobsky @teknium1
fix(telegram): handle parentheses in URLs during MarkdownV2 link conv…
a99ce88 
…ersion

The link regex in format_message used [^)]+ for the URL portion, which
  stopped at the first ) character. URLs with nested parentheses (e.g.
  Wikipedia links like Python_(programming_language)) were improperly parsed.

  Use a better regex, which is the same the Slack adapter uses.
@dsocolobsky @teknium1
fix(tui): make "/tools list" show real colors instead of "?[32m" etc.…
03b1151 
… gibberish

The colored ✓/✗ marks in /tools list, /tools enable, and /tools disable
  were showing up as "?[32m✓ enabled?[0m" instead of green and red. The
  colors come out as ANSI escape codes, but the tui eats
  the ESC byte and replaces it with "?" when those codes are printed
  straight to stdout. They need to go through prompt_toolkit's renderer.

  Fix: capture the command's output and re-print each line through
  _cprint(), the same workaround used elsewhere for #2262. The capture
  buffer fakes isatty()=True so the color helper still emits escapes
  (StringIO.isatty() is False, which would otherwise strip colors).
  The capture path only runs inside the TUI; standalone CLI and tests
  go straight through to real stdout where colors already work.
@dsocolobsky @teknium1
fix(discord): handle properly /slash commands in channels
1e63aa2
@dsocolobsky @teknium1
tests(e2e): test command stripping behavior in Discord
106ae46
@IAvecilla @teknium1
Update env vars for openclaw migration
2e25028
@teknium1
fix: remove duplicate timezone import in e2e conftest
55e8f08
@teknium1
fix: follow-up for salvaged PRs #6293, #7387, #9091, #13131
1ce9b8b 
- Fix duplicate 'timezone' import in e2e conftest
- Fix test_text_before_command_not_detected asserting send() is awaited
  when no agent is present in mock setup (text messages don't produce
  command output)
@github-actions

github-actions Bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

🚨 CRITICAL Supply Chain Risk Detected

This PR contains a pattern that has been used in real supply chain attacks. A maintainer must review the flagged code carefully before merging.

🚨 CRITICAL: Install-hook file added or modified

These files can execute code during package installation or interpreter startup.

Files:

hermes_cli/setup.py

Scanner only fires on high-signal indicators: .pth files, base64+exec/eval combos, subprocess with encoded commands, or install-hook files. Low-signal warnings were removed intentionally — if you're seeing this comment, the finding is worth inspecting.

@trevorgordon981

trevorgordon981 commented Apr 20, 2026

Copy link
Copy Markdown

✅ Review Complete - LGTM

Tested all 4 salvaged bug fixes - all passing:

Test Results

Component Tests Status
Telegram URL parentheses (PR #7387) 88 passed ✅
Discord slash commands (PR #6293) 6 passed ✅
TUI colors (PR #9091) included in 88 above ✅
OpenClaw migration (PR #13131) 33 passed ✅
Total 127 tests ✅ All passing

Detailed Analysis

1. PR #7387 - Telegram URL parentheses fix ✅

  • The regex change from to the Slack adapter's pattern correctly handles Wikipedia-style URLs with nested parens
  • Test coverage is excellent: validates the exact edge case
  • No regressions in the other 87 format tests

2. PR #6293 - Discord slash command detection ✅

  • The approach correctly preserves command text before clobbers it
  • E2E tests validate both channel and DM scenarios
  • The mention-stripping behavior is correctly tested for nicknames vs usernames
  • Follow-up fix for is correct (text messages don't await send())

3. PR #9091 - TUI colors fix ✅

  • The + workaround is the right approach for prompt_toolkit
  • Only activates in TUI mode (standalone CLI/tests unchanged)
  • Validated by the colored output tests in the 88 test suite

4. PR #13131 - OpenClaw migration env var detection ✅

  • Dynamic and lookups are much more maintainable than hardcoded checks
  • Correctly identifies the wrong env vars (SIGNAL_ACCOUNT, WHATSAPP_PHONE_NUMBER_ID)
  • Test coverage validates all migration scenarios (accept/decline/error/missing)

Follow-up Fixes

  • ✅ Duplicate import removed
  • ✅ AUTHOR_MAP entries added for lambdaclass.com emails
  • ✅ Test assertion fixed for non-command text messages

Recommendation

Merge immediately. This is a high-quality salvage PR that:

  1. Preserves contributor authorship (critical for community trust)
  2. Fixes 4 tier-1 bugs affecting core functionality
  3. Has comprehensive test coverage (127 tests passing)
  4. Includes all necessary follow-up fixes

No additional changes needed. Ready for merge.

Reviewer: @teknium1
Tested on: macOS (Apple Silicon), Python 3.11.15
Date: April 20, 2026

@trevorgordon981 trevorgordon981 mentioned this pull request Apr 20, 2026
Closed
13 tasks
@teknium1 teknium1 merged commit 36e8435 into main Apr 20, 2026
2 of 6 checks passed
@teknium1 teknium1 deleted the hermes/hermes-eaac5e6d branch April 20, 2026 21:56
This was referenced Apr 20, 2026
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@teknium1 @trevorgordon981 @dsocolobsky @IAvecilla