feat(api_server): accept input_audio chat parts#13184
Open
manuelschipper wants to merge 1 commit into
Open
Conversation
2e90685 to
556f6c9
Compare
6 tasks
✅ Review Complete - LGTMVerified - input_audio chat parts implemented correctly Feature Analysisinput_audio support ✅
Implementation ✅
Impact ✅
RecommendationMerge immediately. This feature:
Suggest adding e2e tests for audio workflows in a follow-up PR, but the core implementation is solid. Tested on: macOS (Apple Silicon), Python 3.11.15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
input_audiocontent parts on the final user message for/v1/chat/completions./v1/responses, assistant messages, and non-final user-message audio explicitly rejected with OpenAI-shaped errors.Why
The API Server already accepts inline image content parts. This adds the audio side of the same OpenAI-compatible content-part surface without introducing a new provider or credential contract, because it reuses Hermes’ existing voice/STT implementation.
Verification
scripts/run_tests.sh tests/gateway/test_api_server_multimodal.py tests/gateway/test_api_server.py155 passed, 91 warningsNotes