fix(runtime): check providers: dict even for resolved provider aliases#13134
Closed
regoo wants to merge 1 commit into
Closed
fix(runtime): check providers: dict even for resolved provider aliases#13134regoo wants to merge 1 commit into
regoo wants to merge 1 commit into
Conversation
When resolve_provider() successfully maps an alias like 'lmstudio' to 'custom', the code was returning None immediately, skipping the user's providers: dict entirely. This meant custom provider definitions under alias names (e.g. providers.lmstudio) were silently ignored, causing fallback to openrouter. Fix: continue to check providers: dict regardless of built-in alias resolution, allowing user-defined custom providers to shadow aliases.
Collaborator
|
Related to #5956 which also fixes named provider resolution from config.yaml providers: dict. |
Contributor
|
Closing as superseded by #28882. Triage notes (high confidence): Thanks for the contribution — the underlying problem this PR addresses has been resolved by the linked PR on current main. If you believe this was closed in error, please comment and we'll reopen. (Bulk-closed during a CLI PR triage sweep.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
resolve_provider()successfully maps an alias likelmstudiotocustom, the code was returningNoneimmediately, skipping the user'sproviders:dict entirely. This meant custom provider definitions under alias names (e.g.providers.lmstudio) were silently ignored, causing fallback to openrouter.Fix
Continue to check
providers:dict regardless of built-in alias resolution, allowing user-defined custom providers to shadow aliases.Changes
hermes_cli/runtime_provider.py:_get_named_custom_provider()now stores the built-in match result in a flag instead of returning early, allowing the providers: dict check to proceed for all non-auto/non-customrequests.