fix: honor approvals.timeout across CLI and ACP#13088
Open
tomgreeEn wants to merge 1 commit into
Open
Conversation
- make ACP approvals inherit approvals.timeout when no explicit timeout is provided - allow non-positive ACP timeout values to wait indefinitely - make terminal CLI approval UI honor approvals.timeout instead of a hardcoded 60s limit - add focused regression tests for ACP and terminal CLI approval flows Fixes NousResearch#3765.
5793a3b to
9c99e62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
approvals.timeoutfrom config when no explicit timeout is providedapprovals.timeoutinstead of a hardcoded 60s limitProblem
Hermes had two separate 60-second approval timeouts:
This meant
approvals.timeoutinconfig.yamlwas not fully honored, and users could still hit 1-minute expiry in regular terminal sessions even after fixing the ACP path.Test Plan
./venv/bin/python -m pytest tests/acp/test_permissions.py tests/cli/test_cli_approval_ui.py -q -o 'addopts='./venv/bin/python -m py_compile cli.py acp_adapter/permissions.py tests/cli/test_cli_approval_ui.py tests/acp/test_permissions.pyapprovals.timeoutis set higherFixes #3765.