fix(gateway): use persisted session origin for shutdown notifications#13013
Merged
Conversation
Prefer session_store origin over _parse_session_key() for shutdown notifications. Fixes misrouting when chat identifiers contain colons (e.g. Matrix room IDs like !room123:example.org). Falls back to session-key parsing when no persisted origin exists. Co-authored-by: Ruzzgar <ruzzgarcn@gmail.com> Ref: #12766
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use persisted session-store origin for shutdown notification routing instead of reparsing session keys with
_parse_session_key().Fixes misrouting when chat identifiers contain colons (e.g. Matrix room IDs like
!room123:example.org). Falls back to session-key parsing for legacy sessions without persisted origin.Changes
gateway/run.py: Prefersession_store._entries[key].originin_notify_active_sessions_of_shutdown()tests/gateway/restart_test_helpers.py: Wire_entriesdict on mocked session_storetests/gateway/test_restart_drain.py: Regression test for Matrix-style colon-bearing room IDsValidation
!room123:example.org!room12399914/14 restart drain tests pass.
Salvaged from #12766 by @Ruzzgar — cherry-picked with authorship preserved.