fix: close ephemeral agents to prevent fd leaks#12998
Closed
bloodcarter wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Related to #8331 (close leaked cron and gateway resources) — may supersede or overlap. |
3 tasks
Contributor
Author
|
Superseded by #13979, which includes this PR's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cron.scheduler.run_job()so OpenAI/httpx, browser, process, and child-agent resources are released deterministically/background,/btw, and manual/compressclose()is called on success and failure pathsWhy
Long-lived gateway/cron processes were accumulating file descriptors until they hit
EMFILE/Too many open files. Restarting the gateway reset the symptom, but these ephemeralAIAgentinstances were not being closed.Testing
python -m pytest tests/cron/test_scheduler.py::TestRunJobSessionPersistence::test_run_job_passes_session_db_and_cron_platform tests/cron/test_scheduler.py::TestRunJobSessionPersistence::test_run_job_empty_response_returns_empty_not_placeholder tests/cron/test_scheduler.py::TestRunJobSessionPersistence::test_run_job_closes_agent_on_failure tests/gateway/test_compress_focus.py tests/gateway/test_flush_memory_stale_guard.py -qNotes
tests/cron/test_scheduler.pyaround silent delivery / tick behavior; this PR does not modify those paths.