fix(gateway): route watch notifications to correct Discord thread (#10411)#12918
Open
Tranquil-Flow wants to merge 1 commit into
Open
fix(gateway): route watch notifications to correct Discord thread (#10411)#12918Tranquil-Flow wants to merge 1 commit into
Tranquil-Flow wants to merge 1 commit into
Conversation
c70b900 to
708a62c
Compare
708a62c to
85cda71
Compare
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Background process watch notifications can lose the Discord thread context when the stored session origin does not carry the current event thread. This PR uses the event thread information as a fallback so watch notifications return to the thread where the process was started.
Related Issue
Fixes #10411
Type of Change
Changes Made
gateway/run.py.How to Test
.venv/bin/python -m pytest -o 'addopts=' tests/gateway/test_watch_notification_thread_routing.py -qChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests pass — focused pytest passed; full suite was not run in this salvage passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Focused verification: