feat(dingtalk): default registration source to HERMES with disclosure update#12907
Open
meng93 wants to merge 1 commit into
Open
feat(dingtalk): default registration source to HERMES with disclosure update#12907meng93 wants to merge 1 commit into
meng93 wants to merge 1 commit into
Conversation
f88c966 to
ac76df4
Compare
This was referenced Apr 20, 2026
d59e734 to
74615af
Compare
Set DingTalk registration init source to default to HERMES, normalize source handling, and update QR-flow disclosure copy to clarify that users may see Hermes text on DingTalk's authorization page. Add tests to lock in default/normalization behavior and init payload expectations. Made-with: Cursor
63769b8 to
a5cf743
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the follow-up action outlined in #11574:
Now that the Hermes source token has been sanctioned, this PR flips the default registration source from
openClawtoHERMESand updates the disclosure accordingly.What Changed
DINGTALK_REGISTRATION_SOURCEdefault fromopenClawtoHERMES.hermes(lowercase) is normalized toHERMES.OpenClawbranding on the authorization page.{"source": "HERMES"}by default,HERMES,hermes) is normalized toHERMES.Related: Additional Official Enhancements
This PR also pairs well with #12769, which brings proactive messaging, media pipeline, card throttle, and other official platform-level improvements to the DingTalk adapter.
Why
As noted in #11574, once DingTalk-Real-AI confirmed and sanctioned the Hermes source token via the Alibaba channel, the default should reflect the sanctioned identity. This eliminates user confusion around legacy OpenClaw branding while maintaining backward compatibility via the existing
DINGTALK_REGISTRATION_SOURCEenv var escape hatch.Scope
Files changed:
hermes_cli/dingtalk_auth.pytests/hermes_cli/test_dingtalk_auth.pyNo functional changes outside DingTalk registration source handling and related messaging/tests.
Test Plan
tests/hermes_cli/test_dingtalk_auth.pymainonly includes DingTalk auth + testsRisks / Notes
/app/registration/init.DINGTALK_REGISTRATION_SOURCEoverrides still work.