fix(agent): use correct HOME for ~ expansion in skill config resolution#12736
Open
Tranquil-Flow wants to merge 1 commit into
Open
fix(agent): use correct HOME for ~ expansion in skill config resolution#12736Tranquil-Flow wants to merge 1 commit into
Tranquil-Flow wants to merge 1 commit into
Conversation
d49b256 to
3e18951
Compare
This was referenced Apr 23, 2026
40ada4f to
ac62f4e
Compare
ac62f4e to
bbb91a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Skill config path resolution could expand
~against the wrong HOME in profile/container contexts. This PR routes skill config path expansion through the Hermes path helper so tilde expansion follows the intended Hermes environment.Related Issue
Related to skill config path expansion under overridden Hermes homes.
Type of Change
Changes Made
agent/skill_utils.py.hermes_constants.pypath expansion support.How to Test
.venv/bin/python -m pytest -o 'addopts=' tests/agent/test_expand_hermes_path.py -qChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests pass — focused pytest passed; full suite was not run in this salvage passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Focused verification: