terminal: guard foreground server/watch commands (salvage #10810)#12723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #10810 by @etherman-os onto current main.
Summary
Rejects foreground terminal calls that start long-lived servers or use shell-level background wrappers, steering the model to
background=truewith actionable guidance. Complements #8340 (which unblocks the drain-thread hang) by preventing the bad pattern from being issued in the first place.Changes
tools/terminal_tool.py: guard rejectsnohup/disown/setsid/trailing&and long-lived patterns (npm/pnpm/yarn/bun run dev|start|serve|watch,docker compose up,next dev,vite,nodemon,uvicorn,gunicorn,python -m http.server) in foreground mode;--help/--versionvariants unblocked.scripts/release.py: addetherman-osto AUTHOR_MAP.Validation
scripts/run_tests.sh tests/tools/test_terminal_foreground_timeout_cap.py -q— 11 passed.Closes #10810 with authorship preserved via cherry-pick.