fix: restrict think=False to Ollama endpoints only#12488
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
Previously, think=False was sent to ALL custom provider endpoints when reasoning was disabled. Now it only applies when the base_url contains 'ollama' or uses port 11434 (Ollama's default).
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
think=Falsewas being sent to ALL custom provider endpoints when reasoning was disabled, not just Ollama. This could cause errors with non-Ollama custom endpoints that don't recognize thethinkparameter.Fix: added an Ollama endpoint check before setting
think=False. The condition now verifies the base URL containsollamaor uses port11434(Ollama's default port). For any other custom endpoint,think=Falseis no longer injected into the request.Related Issue
Fixes #11237
Type of Change
Changes Made
think=Falseinjection on "is this an Ollama endpoint?" (URL substringollamaor port11434) before adding the parameter.How to Test
thinkis not sent.http://localhost:11434) with reasoning disabled and confirmthink=Falseis still sent (no regression).Checklist
Code
fix:)pytest tests/ -qand all tests passDocumentation & Housekeeping
cli-config.yaml.example— N/ACONTRIBUTING.md/AGENTS.md— N/AScreenshots / Logs
N/A — parameter-gating fix.