fix: accept all document attachments#12468
Open
zesty-clawd wants to merge 2 commits into
Open
Conversation
Treat non-media Discord, Telegram, and Slack uploads as documents instead of skipping unsupported extensions. - Cache unknown file types with a safe fallback MIME type - Preserve plain-text injection for common text-like formats - Add regression tests for JSON and unnamed uploads
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
Discord/Telegram/Slack would skip non-whitelisted document extensions, so files like .json were treated as empty text-only messages.
Root Cause
Each platform adapter gated document handling on SUPPORTED_DOCUMENT_TYPES and rejected any extension not in the allowlist.
Fix
How to Verify
Test Plan
Risk Assessment
Low — the change only broadens document acceptance and keeps existing media handling unchanged.