fix(memory): keep Honcho provider opt-in#12318
Closed
helix4u wants to merge 1 commit into
Closed
Conversation
|
✓ Automated scan: test fixtures only, no real secrets. Honcho opt-in fix. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the Honcho auto-migration path from AIAgent init so a blank
memory.providerstays opt-in. This stops staleHONCHO_API_KEY/HONCHO_BASE_URLfallback state from rewritingmemory.provider: honchoback into config at startup after the user has removed it.Related Issue
N/A
Type of Change
Changes Made
memory.providerdoes not auto-enable Honcho or write config even when Honcho fallback would appear enabled.How to Test
memory.providerto an empty string in~/.hermes/config.yaml.HONCHO_API_KEYorHONCHO_BASE_URLpresent in env /~/.hermes/.env.memory.provider: honchoback into config.Checklist
Code
fix(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Focused tests:
scripts/run_tests.sh tests/run_agent/test_memory_provider_init.py tests/agent/test_memory_provider.py -q61 passed in 4.92sFull suite on this checkout:
scripts/run_tests.sh -q18 failed, 12947 passed, 36 skipped, 187 warnings in 299.58s (0:04:59)