feat(cli): improve multiline previews#12269
Closed
lumenradley wants to merge 1 commit into
Closed
Conversation
Contributor
|
Merged via PR #12934 — your commit was cherry-picked onto current main with authorship preserved (see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves multiline user-message previews in the CLI so submitted prompts are echoed back compactly instead of dumping the entire pasted block into scrollback.
Related Issue
Fixes #TBD
Type of Change
Changes Made
cli.py.display.user_message_previewdefaults inhermes_cli/config.py.tests/cli/test_cli_user_message_preview.py.tests/hermes_cli/test_config.py.How to Test
source /Volumes/Shared/turbo/hermes-agent/venv/bin/activate && scripts/run_tests.sh.scripts/run_tests.sh tests/cli/test_cli_user_message_preview.py tests/hermes_cli/test_config.py -q.hermes, paste a 6+ line block, and verify the echo shows the first 2 lines, an omission marker, and the last 2 lines.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
feat/multiline-preview(974953530261):29 failed, 12918 passed, 38 skipped.upstream/mainbaseline on this machine:34 failed, 12909 passed, 38 skipped.