fix(tests): merge code_execution category and sync hardcoded config version#12139
Closed
Julientalbot wants to merge 1 commit into
Closed
Conversation
…ersion Two CI regressions currently break every open PR against main: 1. `test_no_single_field_categories` — the `code_execution` category in `hermes_cli/config.py` has a single field (`mode`), which violates the assertion that all categories must expose at least two fields after merging. Route `code_execution` through the existing `_CATEGORY_MERGE` map into `terminal` (semantic fit: both deal with shell/exec surface). 2. `test_config_version_matches_current_schema` — `_config_version` was bumped to 19 in `hermes_cli/config.py` but the assertion in `tests/tools/test_browser_camofox_state.py` still hardcodes 18. Sync the expectation. Scope is intentionally limited to the two failing assertions. No behavior change, no functional refactor.
This was referenced Apr 18, 2026
Contributor
Author
|
Closing — not worth carrying a stale 2-line test fix. Filing away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two CI regressions are currently breaking every open PR against
main:1.
test_no_single_field_categories—code_executionsingle-fieldhermes_cli/config.py:775introduces acode_executioncategory with a single field (mode), violatingcount >= 2intests/hermes_cli/test_web_server.py:369.Fix: route
code_executionthrough the existing_CATEGORY_MERGEmap intoterminal(semantic fit: both deal with shell/exec surface).2.
test_config_version_matches_current_schema— stale assertion_config_versionwas bumped to19inhermes_cli/config.py:805buttests/tools/test_browser_camofox_state.py:67still asserts== 18.Fix: sync the expectation to
19.Scope
Intentionally minimal — two assertions, no behavior change, no refactor. Unblocks every PR currently failing CI with these two specific errors (including #12120 where this was spotted).
Test plan