fix(discord): stop truncating flat /skill autocomplete catalog#11804
Closed
Junass1 wants to merge 1 commit into
Closed
fix(discord): stop truncating flat /skill autocomplete catalog#11804Junass1 wants to merge 1 commit into
Junass1 wants to merge 1 commit into
Conversation
…skill autocomplete
4 tasks
Collaborator
|
The underlying cmd_key preservation bug was fixed in PR #19162 (salvaged from #18951 by @CharlieKerfoot). Your PR's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Discord's flat
/skillautocomplete path so it no longer inherits the old category-group cap.Previously, the Discord adapter switched to a flat autocomplete-based
/skillcommand, but still populated it through the legacy category collector. That meant skills could still be silently hidden once the catalog exceeded the old25 groups × 25 skillsshape. Long skill names also risked losing their originalcmd_keybinding after name clamping.What changed
discord_skill_autocomplete_entries()for the flat Discord/skillUIcmd_keywhen clamping long skill names via_clamp_command_triples()Why this is correct
The flat
/skillcommand uses Discord autocomplete rather than registered subcommand groups, so it should not be constrained by the old grouped-command structural limits. This change keeps the existing filtering rules (disabled skills, hub exclusion, reserved-name handling, name clamping) while removing the obsolete cap from the autocomplete path.Testing
tests/hermes_cli/test_commands.py— 110 passedtests/gateway/test_discord_slash_commands.py— 30 passed