fix(gateway): preserve intraword underscores in plain text markdown stripping#11775
Open
Ruzzgar wants to merge 1 commit into
Open
fix(gateway): preserve intraword underscores in plain text markdown stripping#11775Ruzzgar wants to merge 1 commit into
Ruzzgar wants to merge 1 commit into
Conversation
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
gateway.platforms.helpers.strip_markdown()so underscore-based italic stripping only applies at word boundaries.Previously, plain-text content like
foo_bar_bazwas treated as Markdown emphasis and collapsed tofoobarbaz. This affected platform adapters that reuse the shared helper for plain-text delivery, including SMS, BlueBubbles, Feishu, and QQ.What changed
_RE_ITALIC_UNDERto avoid matching underscores inside words_italic_ text->italic textfoo_bar_bazWhy this matters
This is a real user-facing formatting bug in plain-text platform output. It corrupts identifiers, filenames, and other underscore-delimited text even when the content is not Markdown.
Validation
Ran:
scripts/run_tests.sh tests/gateway/test_platform_helpers.pyscripts/run_tests.sh tests/gateway/test_sms.pyscripts/run_tests.sh tests/gateway/test_bluebubbles.pyResults:
test_platform_helpers: 2 passedtest_sms: 36 passedtest_bluebubbles: 45 passedManual smoke:
strip_markdown("foo_bar_baz")->foo_bar_bazstrip_markdown("_italic_ text")->italic text