fix(browser): persist remote browser_vision screenshots locally#11752
Open
sgaofen wants to merge 1 commit into
Open
fix(browser): persist remote browser_vision screenshots locally#11752sgaofen wants to merge 1 commit into
sgaofen wants to merge 1 commit into
Conversation
Contributor
Author
|
CI note: the failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
browser_vision()always passed a local~/.hermes/cache/screenshots/...path into the screenshot command and then immediately expected that same host path to exist. That works for local Chromium, but remote Browserbase/CDP sessions cannot write into WSL or other host-local filesystem paths.Testing
python3 -m py_compile /Users/stephenyu/Documents/hermes-agent-wt-11729/tools/browser_tool.py /Users/stephenyu/Documents/hermes-agent-wt-11729/tests/tools/test_browser_console.pyuv run --directory /Users/stephenyu/Documents/hermes-agent-wt-11729 --extra dev pytest -o addopts='' /Users/stephenyu/Documents/hermes-agent-wt-11729/tests/tools/test_browser_console.py -qPlatform Tested
Contribution Guide Notes
browser_vision()and its regression tests